Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tutorials/advanced_source/super_resolution_with_onnxruntime.py is maybe outdated? #1781

Closed
MaKaNu opened this issue Jan 5, 2022 · 2 comments · Fixed by #2370
Closed

tutorials/advanced_source/super_resolution_with_onnxruntime.py is maybe outdated? #1781

MaKaNu opened this issue Jan 5, 2022 · 2 comments · Fixed by #2370
Labels
content A label for incorrect descriptions that needs to be updated docathon-h1-2023 A label for the docathon in H1 2023 easy

Comments

@MaKaNu
Copy link

MaKaNu commented Jan 5, 2022 •
edited
Loading

I am working at the moment trough the tutorial and realized, that the entry notes are not up-to-date.

  • line 19 says, onnx is available/compatible between 3.5 to 3.7:
    • I tested installation in a venv with 3.9 without problems
  • line 21-22 says, says that the main/master branch is needed:
    • I tested the standard imports from line 26 to 32 and all imports worked without a problem.

I am running a ubuntu 20.04 with torch stable 1.10.1 installed via pip for cuda 10.2.

I did not finished the tutorial yet and will append further informations while continuing.

EDIT:
I can confirm: works without any issues
@svekars svekars added the content A label for incorrect descriptions that needs to be updated label Oct 19, 2022
@svekars svekars added easy docathon-h1-2023 A label for the docathon in H1 2023 labels May 31, 2023
@frasertajima
Copy link
Contributor

\assigntome

frasertajima added a commit to frasertajima/tutorials that referenced this issue May 31, 2023
@frasertajima
Update super_resolution_with_onnxruntime.py
2ab0d07 
Fix for pytorch#1781
"tutorials/advanced_source/super_resolution_with_onnxruntime.py is maybe outdated?"

References to requirements are out of date according to ONNX documentation (https://onnxruntime.ai/docs/reference/compatibility.html) which recommends the latest stable PyTorch version. 

Rather than manually update the version number with the current stable version (e.g., 2.0.1), as long as ONNX maintains compatibility with the lastest stable version that reference should be sufficient and constantly up to date.
@frasertajima frasertajima mentioned this issue May 31, 2023
Merged
4 tasks
svekars pushed a commit that referenced this issue May 31, 2023
@frasertajima
Update super_resolution_with_onnxruntime.py (#2370)
d55a262 
Fix for #1781
Rather than manually update the version number with the current stable version (e.g., 2.0.1), as long as ONNX maintains compatibility with the lastest stable version that reference should be sufficient and constantly up to date.
@frasertajima frasertajima mentioned this issue Jun 1, 2023
Merged
4 tasks
@kit1980
Copy link
Member

kit1980 commented Jun 2, 2023

Closing as fixed by #2370

@kit1980 kit1980 closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content A label for incorrect descriptions that needs to be updated docathon-h1-2023 A label for the docathon in H1 2023 easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update super_resolution_with_onnxruntime.py frasertajima/tutorials
4 participants
@kit1980 @svekars @MaKaNu @frasertajima