Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast the vector from deduced type to desired type if needed. #5416

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Cast the vector from deduced type to desired type if needed. #5416

merged 8 commits into from
Sep 17, 2024

Conversation

pytorchbot
Copy link
Collaborator

Summary: .

Differential Revision: D62807302

@shoumikhin @pytorchbot
Cast the vector from deduced type to desired type if needed. (#5409)
60f45a1 
Summary:
Pull Request resolved: #5409

.

Reviewed By: kirklandsign

Differential Revision: D62807302

fbshipit-source-id: ce71b88c7588367def22e3baf5b835e21b42c8bf
(cherry picked from commit e8a557c)
This was referenced Sep 17, 2024
Open
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5416

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 63ff766 with merge base eecf74f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2024
@dvorjackz
Copy link
Contributor

@shoumikhin pls fix merge conflicts.

Also - seems safe to add, but could you comment on why this is necessary to cp?

@shoumikhin
Copy link
Contributor

@dvorjackz that's a fix for the new tensor ergonomics

@dvorjackz
Copy link
Contributor

Got it, seems like tests are failing

@shoumikhin
Copy link
Contributor

@dvorjackz perhaps I missed something while merging conflicts, so I've updated some of the files to the latest versions from the main branch that's passing.

@dvorjackz dvorjackz merged commit cb200d7 into release/0.4 Sep 17, 2024
34 checks passed
@dvorjackz dvorjackz deleted the cherry-pick-5409-by-pytorch_bot_bot_ branch September 17, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvorjackz dvorjackz dvorjackz approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pytorchbot @dvorjackz @shoumikhin @facebook-github-bot