Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast the vector from deduced type to desired type if needed. #5409

Closed
wants to merge 1 commit into from

Conversation

shoumikhin
Copy link
Contributor

Summary: .

Differential Revision: D62807302

Copy link

pytorch-bot bot commented Sep 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5409

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ddd991c with merge base c605bae (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62807302

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62807302

Summary:
Pull Request resolved: #5409

.

Reviewed By: kirklandsign

Differential Revision: D62807302
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62807302

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e8a557c.

@shoumikhin
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Sep 17, 2024
Summary:
Pull Request resolved: #5409

.

Reviewed By: kirklandsign

Differential Revision: D62807302

fbshipit-source-id: ce71b88c7588367def22e3baf5b835e21b42c8bf
(cherry picked from commit e8a557c)
@pytorchbot
Copy link
Collaborator

Cherry picking #5409

The cherry pick PR is at #5416 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

dvorjackz pushed a commit that referenced this pull request Sep 17, 2024
* Cast the vector from deduced type to desired type if needed. (#5409)

Summary:
Pull Request resolved: #5409

.

Reviewed By: kirklandsign

Differential Revision: D62807302

fbshipit-source-id: ce71b88c7588367def22e3baf5b835e21b42c8bf
(cherry picked from commit e8a557c)

* Update tensor_impl_ptr.h

* Update tensor_impl_ptr.h

* Update tensor_ptr.h

* Update tensor_impl_ptr_test.cpp

* Update tensor_ptr_test.cpp

---------

Co-authored-by: Anthony Shoumikhin <shoumikhin@meta.com>
Co-authored-by: Anthony Shoumikhin <anthony@shoumikh.in>
lucylq pushed a commit that referenced this pull request Sep 17, 2024
Summary:
Pull Request resolved: #5409

.

Reviewed By: kirklandsign

Differential Revision: D62807302

fbshipit-source-id: ce71b88c7588367def22e3baf5b835e21b42c8bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants