Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip annotate boolean input #2999

Closed
wants to merge 1 commit into from
Closed

Skip annotate boolean input #2999

wants to merge 1 commit into from

Conversation

pytorchbot
Copy link
Collaborator

Stack from ghstack (oldest at bottom):

Differential Revision: D55946526

@cccclai @pytorchbot
Skip annotate boolean input (#2957)
3b56b58 
Summary:
Pull Request resolved: #2957

ghstack-source-id: 222200589
exported-using-ghexport

It only makes sense to quantize fp tensor, but not boolean. Add a check to make sure only fp tensor are annotated in quantizer

Reviewed By: jerryzh168

Differential Revision: D55946526

fbshipit-source-id: d94bfee38ab2d29fc9672ab631b4d5d0c5239d25
(cherry picked from commit ce344bc)
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2999

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 3b56b58 with merge base d3326a2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2024
@pytorchbot pytorchbot mentioned this pull request Apr 11, 2024
Closed
@cccclai cccclai mentioned this pull request Apr 11, 2024
Closed
kirklandsign
kirklandsign reviewed Apr 12, 2024
View reviewed changes
backends/qualcomm/quantizer/utils.py
@@ -41,6 +42,18 @@ def decorator(annotator: Callable):

return decorator

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty line

@cccclai
Copy link
Contributor

cccclai commented Apr 16, 2024

Create #3051 instead.

@cccclai cccclai closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirklandsign kirklandsign kirklandsign left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pytorchbot @cccclai @kirklandsign @facebook-github-bot