Skip annotate boolean input #2957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D55946526](https://our.internmc.facebook.com/intern/diff/D55946526/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2957
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 4189e46 with merge base 7d4bafc ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55946526 |
Differential Revision: [D55946526](https://our.internmc.facebook.com/intern/diff/D55946526/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D55946526 |
|
Look good for me. Thanks for your help. |
jerryzh168
reviewed
Apr 11, 2024
jerryzh168
reviewed
Apr 11, 2024
Differential Revision: [D55946526](https://our.internmc.facebook.com/intern/diff/D55946526/) [ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Apr 11, 2024
Pull Request resolved: #2957 ghstack-source-id: 222193714 @exported-using-ghexport It only makes sense to quantize fp tensor, but not boolean. Add a check to make sure only fp tensor are annotated in quantizer Differential Revision: [D55946526](https://our.internmc.facebook.com/intern/diff/D55946526/)
|
This pull request was exported from Phabricator. Differential Revision: D55946526 |
Differential Revision: [D55946526](https://our.internmc.facebook.com/intern/diff/D55946526/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D55946526 |
cccclai
added a commit
that referenced
this pull request
Apr 11, 2024
Pull Request resolved: #2957 ghstack-source-id: 222200589 @exported-using-ghexport It only makes sense to quantize fp tensor, but not boolean. Add a check to make sure only fp tensor are annotated in quantizer Differential Revision: [D55946526](https://our.internmc.facebook.com/intern/diff/D55946526/)
jerryzh168
approved these changes
Apr 11, 2024
|
This pull request has been merged in ce344bc. |
|
@pytorchbot cherry-pick --onto release/0.2 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 11, 2024
Summary: Pull Request resolved: #2957 ghstack-source-id: 222200589 exported-using-ghexport It only makes sense to quantize fp tensor, but not boolean. Add a check to make sure only fp tensor are annotated in quantizer Reviewed By: jerryzh168 Differential Revision: D55946526 fbshipit-source-id: d94bfee38ab2d29fc9672ab631b4d5d0c5239d25 (cherry picked from commit ce344bc)
Cherry picking #2957The cherry pick PR is at #2999 and it is recommended to link a critical cherry pick PR with an issue Details for Dev Infra teamRaised by workflow job |
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Apr 16, 2024
Summary: Pull Request resolved: pytorch#2957 ghstack-source-id: 222200589 exported-using-ghexport It only makes sense to quantize fp tensor, but not boolean. Add a check to make sure only fp tensor are annotated in quantizer Reviewed By: jerryzh168 Differential Revision: D55946526 fbshipit-source-id: d94bfee38ab2d29fc9672ab631b4d5d0c5239d25
guangy10
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Skip annotate boolean input (#2957) Summary: Pull Request resolved: #2957 ghstack-source-id: 222200589 exported-using-ghexport It only makes sense to quantize fp tensor, but not boolean. Add a check to make sure only fp tensor are annotated in quantizer Reviewed By: jerryzh168 Differential Revision: D55946526 fbshipit-source-id: d94bfee38ab2d29fc9672ab631b4d5d0c5239d25 * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D55946526