Android demo app tutorial fix for XNNPACK and QNN #2962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kirklandsign
commented
Apr 10, 2024
kirklandsign
commented
- Update tutorial due to recent changes.
- Clean up setup.sh for app helper lib build.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2962
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit caf2545 with merge base b26eee8 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I will rebase this one once #2956 is merged |
kirklandsign
force-pushed
the
android-dl3-fix
branch
from
efb7b0b
to
caf2545
Compare
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cccclai
approved these changes
Apr 10, 2024
|
@kirklandsign merged this pull request in 26365f1. |
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 11, 2024
Summary: * Update tutorial due to recent changes. * Clean up setup.sh for app helper lib build. Pull Request resolved: pytorch#2962 Reviewed By: cccclai Differential Revision: D55951189 Pulled By: kirklandsign fbshipit-source-id: 2c95e8580145b039f503e7cd99a4003867f8dbb0 (cherry picked from commit 26365f1)
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 12, 2024
Summary: * Update tutorial due to recent changes. * Clean up setup.sh for app helper lib build. Pull Request resolved: pytorch#2962 Reviewed By: cccclai Differential Revision: D55951189 Pulled By: kirklandsign fbshipit-source-id: 2c95e8580145b039f503e7cd99a4003867f8dbb0 (cherry picked from commit 26365f1)
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 12, 2024
Summary: * Update tutorial due to recent changes. * Clean up setup.sh for app helper lib build. Pull Request resolved: pytorch#2962 Reviewed By: cccclai Differential Revision: D55951189 Pulled By: kirklandsign fbshipit-source-id: 2c95e8580145b039f503e7cd99a4003867f8dbb0 (cherry picked from commit 26365f1)
kirklandsign
added a commit
to kirklandsign/executorch
that referenced
this pull request
Apr 12, 2024
Summary: * Update tutorial due to recent changes. * Clean up setup.sh for app helper lib build. Pull Request resolved: pytorch#2962 Reviewed By: cccclai Differential Revision: D55951189 Pulled By: kirklandsign fbshipit-source-id: 2c95e8580145b039f503e7cd99a4003867f8dbb0 (cherry picked from commit 26365f1)
huydhn
added a commit
that referenced
this pull request
Apr 13, 2024
To see if it fixes the Android app
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
Summary: This fixes the issue when the demo Android app fails to load llama2 model and returns an exit code 20. As this failure can be captured by running the instrumentation test suite on Android devices, I also add the test spec that I'm using there for future reference. ### Testing https://github.com/pytorch/executorch/actions/runs/8682469360/job/23808274556?pr=3032#step:12:80 loads the model successfully and shows the observed TSP now Pull Request resolved: #3032 Reviewed By: kirklandsign Differential Revision: D56124177 Pulled By: huydhn fbshipit-source-id: 7cc3987d186e670143f2ca739d29f02649091ec2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.