Fix tutorial for Qualcomm AI Engine Direct Backend #2956
Conversation
We have refactors recently and need to update the tutorial and cmake
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2956
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b152bbc with merge base b26eee8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
added
the
partner: qualcomm
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| @@ -253,7 +253,7 @@ target_link_libraries(qnn_executorch_backend | |||
| qnn_executorch_header | |||
| qnn_schema | |||
| qnn_manager | |||
| executorch | |||
| executorch_no_prim_ops | |||
There was a problem hiding this comment.
how do we link it with prim ops lib?
There was a problem hiding this comment.
In
executorch/examples/qualcomm/CMakeLists.txt
Lines 102 to 108 in 687425d
For other users, add executorch explicitly to binary helps
There was a problem hiding this comment.
TLDR is for users who use qnn_executorch_backend as a dependency, it should also have executorch as a dependency now.
| mkdir cmake_android_out | ||
| cd cmake_android_out |
There was a problem hiding this comment.
why this change is needed?
There was a problem hiding this comment.
can use old one. simply it's already in gitignore.
There was a problem hiding this comment.
let's use the old one probably? Try to make the change minimum
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@chiwwang can you help with tagging reviewers? |
|
Hey @chuntl , may I know if you're able to give this a try? |
|
Rebase to mainline and do the "./install_requirements.sh“ meet the target missing issue:
It seems there're some WIP PRs to fix the CI issue and affect to test this PR. |
Got it. |
Yes, It looks good to me. But it's better to double-check after the error fixed. |
| -DCMAKE_INSTALL_PREFIX=$PWD \ | ||
| -DEXECUTORCH_BUILD_SDK=ON \ | ||
| -DEXECUTORCH_BUILD_QNN=ON \ |
There was a problem hiding this comment.
Possibly need something like CMAKE_INSTALL_PREFIX if we don't want to require root priviledge.
mmmm... would it be a good idea to leave a reminder here?
Since we updated https://github.com/pytorch/executorch/blob/main/build/cmake_deps.toml, we need to |
|
This PR looks good to me, thank you! |
|
@kirklandsign merged this pull request in c7fd394. |
Summary: We have refactors recently and need to update the tutorial and cmake. See pytorch#2955 for isseues. Pull Request resolved: pytorch#2956 Reviewed By: mcr229, cccclai Differential Revision: D55947725 Pulled By: kirklandsign fbshipit-source-id: f23af28b9a8fe071223d8ffa922a6cd4e49efe61 (cherry picked from commit c7fd394)
Summary: We have refactors recently and need to update the tutorial and cmake. See pytorch#2955 for isseues. Pull Request resolved: pytorch#2956 Reviewed By: mcr229, cccclai Differential Revision: D55947725 Pulled By: kirklandsign fbshipit-source-id: f23af28b9a8fe071223d8ffa922a6cd4e49efe61 (cherry picked from commit c7fd394)
Summary: We have refactors recently and need to update the tutorial and cmake. See pytorch#2955 for isseues. Pull Request resolved: pytorch#2956 Reviewed By: mcr229, cccclai Differential Revision: D55947725 Pulled By: kirklandsign fbshipit-source-id: f23af28b9a8fe071223d8ffa922a6cd4e49efe61 (cherry picked from commit c7fd394)
Summary: We have refactors recently and need to update the tutorial and cmake. See #2955 for isseues. Pull Request resolved: #2956 Reviewed By: mcr229, cccclai Differential Revision: D55947725 Pulled By: kirklandsign fbshipit-source-id: f23af28b9a8fe071223d8ffa922a6cd4e49efe61 (cherry picked from commit c7fd394)
We have refactors recently and need to update the tutorial and cmake.
See #2955 for isseues.