Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qLogNEI **kwargs removal #2406

Closed
wants to merge 3 commits into from
Closed

qLogNEI **kwargs removal #2406

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
640d83e
qLogNEI **kwargs removal (#2406)
Jul 2, 2024
6a40914
Merge branch 'main' into export-D59238948
hvarfner Jul 2, 2024
82d6e2d
Merge branch 'main' into export-D59238948
hvarfner Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions botorch/acquisition/logei.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

from functools import partial

from typing import Any, Callable, List, Optional, Tuple, TypeVar, Union
from typing import Callable, List, Optional, Tuple, TypeVar, Union

import torch
from botorch.acquisition.cached_cholesky import CachedCholeskyMCSamplerMixin
Expand Down Expand Up @@ -275,7 +275,7 @@ def __init__(
cache_root: bool = True,
tau_max: float = TAU_MAX,
tau_relu: float = TAU_RELU,
**kwargs: Any,
marginalize_dim: Optional[int] = None,
) -> None:
r"""q-Noisy Expected Improvement.

Expand Down Expand Up @@ -314,7 +314,7 @@ def __init__(
approximations to max.
tau_relu: Temperature parameter controlling the sharpness of the smooth
approximations to ReLU.
kwargs: Here for qNEI for compatibility.
marginalize_dim: The dimension to marginalize over.

TODO: similar to qNEHVI, when we are using sequential greedy candidate
selection, we could incorporate pending points X_baseline and compute
Expand Down Expand Up @@ -343,7 +343,7 @@ def __init__(
posterior_transform=posterior_transform,
prune_baseline=prune_baseline,
cache_root=cache_root,
**kwargs,
marginalize_dim=marginalize_dim,
)

def _sample_forward(self, obj: Tensor) -> Tensor:
Expand Down Expand Up @@ -372,7 +372,7 @@ def _init_baseline(
posterior_transform: Optional[PosteriorTransform] = None,
prune_baseline: bool = False,
cache_root: bool = True,
**kwargs: Any,
marginalize_dim: Optional[int] = None,
) -> None:
CachedCholeskyMCSamplerMixin.__init__(
self, model=model, cache_root=cache_root, sampler=sampler
Expand All @@ -383,7 +383,7 @@ def _init_baseline(
X=X_baseline,
objective=objective,
posterior_transform=posterior_transform,
marginalize_dim=kwargs.get("marginalize_dim"),
marginalize_dim=marginalize_dim,
constraints=self._constraints,
)
self.register_buffer("X_baseline", X_baseline)
Expand Down
Loading