qLogNEI **kwargs removal #2406
Closed
qLogNEI **kwargs removal #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59238948 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2406 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 189 189
Lines 16666 16666
=======================================
Hits 16664 16664
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D59238948 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Jul 2, 2024
Summary: Pull Request resolved: pytorch#2406 Removed the ability for qLogNEI to swallow unused kwargs. Reviewed By: saitcakmak Differential Revision: D59238948
hvarfner
force-pushed
the
export-D59238948
branch
from
b0fd166 to
a577eda
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59238948 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Jul 2, 2024
Summary: Pull Request resolved: pytorch#2406 Removed the ability for qLogNEI to swallow unused kwargs. Reviewed By: saitcakmak Differential Revision: D59238948
hvarfner
force-pushed
the
export-D59238948
branch
from
a577eda to
72e2596
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59238948 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Jul 2, 2024
Summary: Pull Request resolved: pytorch#2406 Removed the ability for qLogNEI to swallow unused kwargs. Reviewed By: saitcakmak Differential Revision: D59238948
hvarfner
force-pushed
the
export-D59238948
branch
from
72e2596 to
942279a
Compare
Summary: Pull Request resolved: pytorch#2406 Removed the ability for qLogNEI to swallow unused kwargs. Reviewed By: saitcakmak Differential Revision: D59238948
|
This pull request was exported from Phabricator. Differential Revision: D59238948 |
hvarfner
force-pushed
the
export-D59238948
branch
from
942279a to
640d83e
Compare
|
The docs failure is unrelated and should be fixed by a diff that just landed. |
|
This pull request has been merged in 0455dc3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Removed the ability for qLogNEI to swallow unused kwargs.
Differential Revision: D59238948