Support observed noise in MixedSingleTaskGP #2054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50394746 |
Codecov Report
@@ Coverage Diff @@
## main #2054 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 179 179
Lines 15847 15802 -45
=========================================
- Hits 15847 15802 -45
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request was exported from Phabricator. Differential Revision: D50394746 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2054 Supporting observed noise was blocked on `SingleTaskGP` not supporting `train_Yvar`. We can easily support it after pytorch#2052 Reviewed By: esantorella Differential Revision: D50394746 fbshipit-source-id: d830d92031b4c3a1b190ce438cdf0513130ae2b0
saitcakmak
force-pushed
the
export-D50394746
branch
from
1358a3f to
f70c8ec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50394746 |
Summary: Supporting an optional `train_Yvar` argument in `SingleTaskGP` eliminates the need for an additional model class just to have a different likelihood. The plan for `FixedNoiseGP` is for it to live along with a soft deprecation warning for the foreseeable future. Differential Revision: D50392099 fbshipit-source-id: 42d2e94ae2114c0311e21194930039e64aec4092
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: 8e417e089cdef694f2ec0891b286c18477673037
Summary: Pull Request resolved: pytorch#2054 Supporting observed noise was blocked on `SingleTaskGP` not supporting `train_Yvar`. We can easily support it after pytorch#2052 Reviewed By: esantorella Differential Revision: D50394746 fbshipit-source-id: 54b87ce99db243d8e6ce88a33a7023edf5338d4c
|
This pull request was exported from Phabricator. Differential Revision: D50394746 |
saitcakmak
force-pushed
the
export-D50394746
branch
from
f70c8ec to
c29dd4a
Compare
|
This pull request has been merged in 818e1c9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Supporting observed noise was blocked on
SingleTaskGPnot supportingtrain_Yvar. We can easily support it after #2052Differential Revision: D50394746