Deprecate FixedNoiseMultiFidelityGP #2053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50393050 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: D50393050
saitcakmak
force-pushed
the
export-D50393050
branch
from
707da73 to
757c932
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50393050 |
Codecov Report
@@ Coverage Diff @@
## main #2053 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 179 179
Lines 15847 15806 -41
=========================================
- Hits 15847 15806 -41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: D50393050
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: e5f628d5da8b51dd6aadc1f09e9abd25cfb2ae64
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: 8ee47d06caede6f918bdb1b62f953016e6b5031d
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: dcb19a14bf2ac799720e7c63371766a8c60e6154
|
This pull request was exported from Phabricator. Differential Revision: D50393050 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: D50393050 fbshipit-source-id: 44dfea109701f5b033889358fdd5222af1c5cda9
saitcakmak
force-pushed
the
export-D50393050
branch
from
757c932 to
64665d6
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 18, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: 710d6c6da7eccb02f944d01996d27fa55c7ed4cb
Summary: Supporting an optional `train_Yvar` argument in `SingleTaskGP` eliminates the need for an additional model class just to have a different likelihood. The plan for `FixedNoiseGP` is for it to live along with a soft deprecation warning for the foreseeable future. Differential Revision: D50392099 fbshipit-source-id: 7d11c2e303240316cf8ff7ff5b91c89e0406d2db
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Reviewed By: Balandat Differential Revision: D50393050 fbshipit-source-id: 57ef592e2281d2ffdb85a1d3ea06e741c35df904
|
This pull request was exported from Phabricator. Differential Revision: D50393050 |
saitcakmak
force-pushed
the
export-D50393050
branch
from
64665d6 to
0e4a234
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: 8e417e089cdef694f2ec0891b286c18477673037
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 19, 2023
Summary: Pull Request resolved: pytorch#2053 Builds on pytorch#2052 to deprecate one more model that existed only to support a different likelihood. Differential Revision: https://internalfb.com/D50393050 fbshipit-source-id: f780903926c108117c7978bdde7c4357a712a50b
|
This pull request has been merged in d98d8fd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Builds on #2052 to deprecate one more model that existed only to support a different likelihood.
Differential Revision: D50393050