Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add utility for constructing rounding input transforms #1531

Closed
wants to merge 4 commits into from

Conversation

sdaulton
Copy link
Contributor

Summary: see title

Differential Revision: D41497584

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Nov 29, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41497584

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1531 (e5d5ff0) into main (d026e80) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e5d5ff0 differs from pull request most recent head fc1770d. Consider uploading reports for the commit fc1770d to get more accurate results

@@            Coverage Diff            @@
##              main     #1531   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          165       166    +1     
  Lines        14284     14349   +65     
=========================================
+ Hits         14284     14349   +65     
Impacted Files Coverage Δ
botorch/models/transforms/utils.py 100.00% <ø> (ø)
botorch/models/transforms/__init__.py 100.00% <100.00%> (ø)
botorch/models/transforms/factory.py 100.00% <100.00%> (ø)
botorch/models/transforms/input.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41497584

sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 30, 2022
Summary:
Pull Request resolved: pytorch#1531

see title

Differential Revision: D41497584

fbshipit-source-id: e6f28402c9a15ba92dbbc22b36e5e06457554166
sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 30, 2022
Summary:
Pull Request resolved: pytorch#1531

see title

Differential Revision: https://internalfb.com/D41497584

fbshipit-source-id: d9ade519cbb4c5740c401ed0c6d9b2c3296194de
sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 30, 2022
Summary:
Pull Request resolved: pytorch#1531

see title

Differential Revision: https://internalfb.com/D41497584

fbshipit-source-id: c5c23c4ce90ccdf8232733384e45c8894d1c6fe2
sdaulton added a commit to sdaulton/botorch that referenced this pull request Nov 30, 2022
Summary:
Pull Request resolved: pytorch#1531

see title

Differential Revision: https://internalfb.com/D41497584

fbshipit-source-id: f9a4b481473393a7664766a4d16f7e2051dcd190
@esantorella esantorella marked this pull request as draft January 2, 2023 18:47
sdaulton added a commit to sdaulton/botorch that referenced this pull request Feb 4, 2023
Summary:
Pull Request resolved: pytorch#1531

see title

Differential Revision: https://internalfb.com/D41497584

fbshipit-source-id: 665bc082482a05101b8182c903837bae89029ed6
sdaulton added a commit to sdaulton/botorch that referenced this pull request Feb 4, 2023
Summary:
Pull Request resolved: pytorch#1531

see title

Reviewed By: Balandat

Differential Revision: D41497584

fbshipit-source-id: 01870496f3b5a5668b6fbf420eb7b4c6fcf57400
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41497584

sdaulton added a commit to sdaulton/botorch that referenced this pull request Feb 4, 2023
Summary:
Pull Request resolved: pytorch#1531

see title

Differential Revision: https://internalfb.com/D41497584

fbshipit-source-id: 1f24d96dc44fa43e78d68b952ad030c334e4ff39
sdaulton added a commit to sdaulton/botorch that referenced this pull request Feb 4, 2023
Summary:
Pull Request resolved: pytorch#1531

see title

Differential Revision: https://internalfb.com/D41497584

fbshipit-source-id: 208098b14ccb3030e6d0e7185d05e0e60adeb0b3
sdaulton added a commit to sdaulton/botorch that referenced this pull request Feb 4, 2023
Summary:
Pull Request resolved: pytorch#1531

see title

Differential Revision: https://internalfb.com/D41497584

fbshipit-source-id: e52e2cb3c2843199f592e3ec098d7fdb080df24b
sdaulton added a commit to sdaulton/botorch that referenced this pull request Feb 6, 2023
Summary:
Pull Request resolved: pytorch#1531

see title

Reviewed By: Balandat

Differential Revision: D41497584

fbshipit-source-id: 7a2b934d1f13ea903583b7d891ab01b63f7e2388
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41497584

sdaulton added a commit to sdaulton/botorch that referenced this pull request Feb 6, 2023
Summary:
Pull Request resolved: pytorch#1531

see title

Reviewed By: Balandat

Differential Revision: D41497584

fbshipit-source-id: 3e2e7fdc47560776acc260f43d10cbb91870582e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41497584

sdaulton and others added 4 commits February 6, 2023 11:41
Summary:
Pull Request resolved: pytorch#1517

see title

Differential Revision: https://internalfb.com/D41482322

fbshipit-source-id: 9fac1eacc7097e11183fd54395cd517a33ce6546
Summary:
Pull Request resolved: pytorch#1518

see title. This bumps the tolerances. This was flaky locally.

Differential Revision: https://internalfb.com/D41482368

fbshipit-source-id: a6dfe2675a2ce078e2c3a6151176d4edeacf08d3
Summary:
Pull Request resolved: pytorch#1656

see title. This is important for being able to set the device with `to()`

Differential Revision: https://internalfb.com/D43048429

fbshipit-source-id: 4f4150255c9856eb9a98e4f151577b68a1fd54fa
Summary:
Pull Request resolved: pytorch#1531

see title

Reviewed By: Balandat

Differential Revision: D41497584

fbshipit-source-id: a3294a28e1ccec48e1e19a0d0685403a3aa4b7e6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41497584

sdaulton added a commit to sdaulton/botorch that referenced this pull request Feb 6, 2023
Summary:
Pull Request resolved: pytorch#1531

see title

Differential Revision: https://internalfb.com/D41497584

fbshipit-source-id: 0d298a6c993ba026abcb98a6926e5ba92e454002
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6475503.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants