Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make indices a buffer in AffineInputTransform #1656

Closed
wants to merge 3 commits into from

Conversation

sdaulton
Copy link
Contributor

@sdaulton sdaulton commented Feb 6, 2023

Summary: see title. This is important for being able to set the device with to()

Reviewed By: Balandat, SebastianAment

Differential Revision: D43048429

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Feb 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43048429

sdaulton and others added 3 commits February 6, 2023 10:03
Summary:
Pull Request resolved: pytorch#1517

see title

Differential Revision: https://internalfb.com/D41482322

fbshipit-source-id: c29a0a785075a37729c9bc313fe127a10cae5a3d
Summary:
Pull Request resolved: pytorch#1518

see title. This bumps the tolerances. This was flaky locally.

Differential Revision: https://internalfb.com/D41482368

fbshipit-source-id: 31c92405eee538fd82b11624ee990e5ed663f744
Summary:
Pull Request resolved: pytorch#1656

see title. This is important for being able to set the device with `to()`

Reviewed By: Balandat, SebastianAment

Differential Revision: D43048429

fbshipit-source-id: 03badccd73481f3c9071a1f08534bc289f4bc49a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43048429

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1656 (52d3d8a) into main (d026e80) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1656   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          165       165           
  Lines        14284     14321   +37     
=========================================
+ Hits         14284     14321   +37     
Impacted Files Coverage Δ
botorch/models/transforms/input.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sdaulton added a commit to sdaulton/botorch that referenced this pull request Feb 6, 2023
Summary:
Pull Request resolved: pytorch#1656

see title. This is important for being able to set the device with `to()`

Differential Revision: https://internalfb.com/D43048429

fbshipit-source-id: 4f4150255c9856eb9a98e4f151577b68a1fd54fa
sdaulton added a commit to sdaulton/botorch that referenced this pull request Feb 6, 2023
Summary:
Pull Request resolved: pytorch#1656

see title. This is important for being able to set the device with `to()`

Differential Revision: https://internalfb.com/D43048429

fbshipit-source-id: c36c46c8f48eb63ca157338ead65b7e1315ebd94
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d80b556.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants