Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typos in documents #998

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Conversation

yoshida-ryuhei
Copy link
Contributor

Description

Correct typos in documents.

Type of change

  • This change requires a documentation update

Checklist:

  • [ ] My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests to verify my fix or my feature
  • [ ] New and existing unit tests pass locally with my changes

I am not sure that correcting this directory docs/_sources/ is adequate or not.
If I should correct another directory, plese let me know.

yoshida-ryuhei and others added 2 commits April 20, 2022 11:47
Signed-off-by: Ryuhei Yoshida <ryuhei.yoshida@aillis.jp>
@narendasan
Copy link
Collaborator

Thanks for the fixes. However, you are editing the pre rendered docs and not the doc source (//docsrc). Just modifying the rst files will be sufficient. CI will build the docs for you

@yoshida-ryuhei
Copy link
Contributor Author

Thanks for reviewing my pull request.
I overlooked the directory //docsrc folder. So, I will correct the //docsrc.

Signed-off-by: Ryuhei Yoshida <yoshida.ryuhei0112@gmail.com>
This reverts commit 5b4bd38.

Signed-off-by: Ryuhei Yoshida <yoshida.ryuhei0112@gmail.com>
@yoshida-ryuhei
Copy link
Contributor Author

Now I have changed the directory to correct the document.
I am happy if you review the code.

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 919b9e9 into pytorch:master Apr 26, 2022
@yoshida-ryuhei yoshida-ryuhei deleted the correct_doc branch March 11, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants