Skip to content

Commit

Permalink
Merge pull request #998 from yoshida-ryuhei/correct_doc
Browse files Browse the repository at this point in the history
Correct typos in documents
  • Loading branch information
narendasan authored Apr 26, 2022
2 parents 7a6a871 + afe8fd9 commit 919b9e9
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 9 deletions.
3 changes: 2 additions & 1 deletion docsrc/contributors/conversion.rst
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ inputs and assemble an array of resources to pass to the converter. Inputs can b

* The input is an output of a node that has already been converted

* In this case the ITensor of the output has added to the to the ``value_tensor_map``,
* In this case the ITensor of the output has added to the ``value_tensor_map``,
The conversion stage will add the ITensor to the list of args for the converter

* The input is from a node that produces a static value
Expand All @@ -32,6 +32,7 @@ inputs and assemble an array of resources to pass to the converter. Inputs can b
static value has been evaluated

* The input is from a node that has not been converted

* Torch-TensorRT will error out here

Node Evaluation
Expand Down
2 changes: 1 addition & 1 deletion docsrc/contributors/lowering.rst
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ Removes _all_ tuples and raises an error if some cannot be removed, this is used
Module Fallback
*****************

`Torch-TensorRT/core/lowering/passes/module_fallback.cpp <https://github.com/nvidia/Torch-TensorRT/blob/master/core/lowering/passes/module_fallback.cpp>`
`Torch-TensorRT/core/lowering/passes/module_fallback.cpp <https://github.com/nvidia/Torch-TensorRT/blob/master/core/lowering/passes/module_fallback.cpp>`_

Module fallback consists of two lowering passes that must be run as a pair. The first pass is run before freezing to place delimiters in the graph around modules
that should run in PyTorch. The second pass marks nodes between these delimiters after freezing to signify they should run in PyTorch.
Expand Down
6 changes: 3 additions & 3 deletions docsrc/contributors/partitioning.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
Partitioning Phase
====================

The phase is optional and enabled by the user. It instructs the compiler to seperate nodes into ones that should run in PyTorch and ones that should run in TensorRT.
Criteria for seperation include: Lack of a converter, operator is explicitly set to run in PyTorch by the user or the node has a flag which tells partitioning to
run in PyTorch by the module fallback passes.
The phase is optional and enabled by the user. It instructs the compiler to separate nodes into ones that should run in PyTorch and ones that should run in TensorRT.
Criteria for separation include: Lack of a converter, operator is explicitly set to run in PyTorch by the user or the node has a flag which tells partitioning to
run in PyTorch by the module fallback passes.
6 changes: 3 additions & 3 deletions docsrc/contributors/phases.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ TensorRT.

Partitioning
^^^^^^^^^^^^^
:ref:`partitioning
:ref:`partitioning`

The phase is optional and enabled by the user. It instructs the compiler to seperate nodes into ones that should run in PyTorch and ones that should run in TensorRT.
Criteria for seperation include: Lack of a converter, operator is explicitly set to run in PyTorch by the user or the node has a flag which tells partitioning to
The phase is optional and enabled by the user. It instructs the compiler to separate nodes into ones that should run in PyTorch and ones that should run in TensorRT.
Criteria for separation include: Lack of a converter, operator is explicitly set to run in PyTorch by the user or the node has a flag which tells partitioning to
run in PyTorch by the module fallback passes.

Conversion
Expand Down
2 changes: 1 addition & 1 deletion docsrc/contributors/system_overview.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ The repository is structured into:
The C++ API is unstable and subject to change until the library matures, though most work is done under the hood in the core.

The core has a couple major parts: The top level compiler interface which coordinates ingesting a module, lowering,
converting and generating a new module and returning it back to the user. The there are the three main phases of the
converting and generating a new module and returning it back to the user. There are the three main phases of the
compiler, the lowering phase, the conversion phase, and the execution phase.

.. include:: phases.rst

0 comments on commit 919b9e9

Please sign in to comment.