-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a section "Stub package versioning" #10840
Conversation
Any suggestions welcome! This will of course need an update if the discussion in #10837 concludes that we update our versioning scheme. |
Could we also explicitly recommend against using mypy's I guess it's not ideal for us to single out a specific option for a specific type checker, but it is still the most widely used type checker. |
Isn't |
Yes. It's unfortunately very widely used, however, so I think there'd be an outcry if mypy even tried to deprecate it :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great! A few wording suggestions:
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Remove a confusing strategy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thanks!
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(A little late to this, so I haven't read the existing resolved comments)
Thank you for documenting this!
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
I think I integrated all comments, but I wouldn't be surprised if there's still a lot of fine-tuning possible in future PRs. |
No description provided.