-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communicating our versioning policy better #10837
Comments
I'd like to bump this again. I still think we should at least bump the minimum stub version up to 1000 to signify that it's "special", although I really like the idea to use the current date. A version like 1.2.3.231012 looks weird, but it really stands out. Any opinions? |
I like the date versioning (aka calver) idea, and I think it would be a good fit for typeshed. Maybe we should use full years in the version number, as in |
We also don't need to limit the uploads. Just use the next free date if the current date is already in use. I don't think it's a problem if a package is a day in the future from time to time. |
IMO it would be better to limit the uploads. Suppose a contributor is doing large manual changes into a specific package, and makes 5 pull requests with 3 hours between each PR (total time spent would be 12 hours, so not unreasonable). If we merge the PRs quickly, this would get stub-uploader 4 days ahead in one day. |
I agree with @Akuli. I also think limiting uploads of any one stubs package to once per day is fine. That's already a much more frequent release schedule than you'll get with basically any other open-source package. |
This is a preparation for python/typeshed#10837, where we switch to date-based versioning system for the uploaded stubs.
This is a preparation for python/typeshed#10837, where we switch to date-based versioning system for the uploaded stubs.
And it worked (ignoring the integration test failures): https://pypi.org/project/types-networkx/3.1.0.20231220/ |
#10825 made it clear that we need to communicate our versioning policy better. The first step is to add a note about it to package descriptions as suggested by me in typeshed-internal/stub_uploader#104. But I think we could also communicate the "specialness" of the typeshed part of the version number better. A few ideas:
Personally, I think options 1 and 2 combined would be a good solution, although I find option 3 strangely appealing as well.
The text was updated successfully, but these errors were encountered: