Treat underscore variables as anonymous #3125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Apr 4, 2017
test-data/unit/check-basic.test
Outdated
| (_, _) = (1.0, "") | ||
| for (_, _) in ((1, "a"), (2, "b")): pass | ||
|
|
||
| def f(_: int, _: str) -> None: pass |
There was a problem hiding this comment.
This actually gives SyntaxError: duplicate argument '_' in function definition at runtime (also in Python 2 with annotations removed).
ilevkivskyi
requested changes
Apr 13, 2017
There was a problem hiding this comment.
I see few problems with this PR:
- you mention "fix Allow
Anytypes for tuple except handler tests #1639" in the PR description, but this seems to be a typo, the mentioned PR seems to be unrelated. - We probably should not drop all type checking for variables named
_, the reason is that it is frequently used forgettextand i18n. Possible solutions would be to only drop type checking if_variable is never read, see Type error due to repeated use of underscore as dummy assignment target #465, or maybe keep type checking_if it has an explicitly declared type. - this needs to be documented.
|
Thanks. I have fixed the issue reference. |
|
There are some ideas in #1332. I will give it some thought. |
|
Since we want to continue the usage of |
|
Ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
#1639#1649: allow(_, _) = (1, "")There's no test for usage of underscores. I don't know how to define when and where this is legal (although pretty common in some frameworks)