Allow Any types for tuple except handler tests
#1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| all_types = [] # type: List[Type] | ||
| test_types = type.items if isinstance(type, TupleType) else [type] | ||
|
|
||
| for ttype in test_types: | ||
| if isinstance(ttype, AnyType): | ||
| all_types.append(ttype) |
There was a problem hiding this comment.
You can just return AnyType() here instead. UnionType.make_simplified_union returns AnyType if any of the types passed to it are AnyType (as it should).
There was a problem hiding this comment.
After looking at your tests, I take it back. The way you're doing it here correctly catches additional non-Exception-derived types that come after an Any.
|
Looks good, thanks! |
|
Thanks @ddfisher! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1635.