Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few PR links in the changelog #18586

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Fix a few PR links in the changelog #18586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ repos:
rev: v1.0.1
hooks:
- id: zizmor
- repo: local
hooks:
- id: bad-pr-link
name: Bad PR link
description: Detect PR links text that don't match their URL
language: pygrep
entry: '\[(\d+)\]\(https://github.com/python/mypy/pull/(?!\1/?\))\d+/?\)'
files: CHANGELOG.md
# Should be the last one:
- repo: meta
hooks:
Expand Down
6 changes: 3 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ By default, mypy treats an annotation of ``bytes`` as permitting ``bytearray`` a
[PEP 688](https://peps.python.org/pep-0688) specified the removal of this special case.
Use this flag to disable this behavior. `--strict-bytes` will be enabled by default in **mypy 2.0**.

Contributed by Ali Hamdan (PR [18137](https://github.com/python/mypy/pull/18263/)) and
Contributed by Ali Hamdan (PR [18263](https://github.com/python/mypy/pull/18263)) and
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detected with the pre-commit hook

Shantanu Jain (PR [13952](https://github.com/python/mypy/pull/13952)).

### Improvements to reachability analysis and partial type handling in loops
Expand All @@ -36,7 +36,7 @@ issues it previously did not detect. In some cases, this change may require use
explicit annotation of a variable.

Contributed by Christoph Tyralla (PR [18180](https://github.com/python/mypy/pull/18180),
[PR](https://github.com/python/mypy/pull/18433)).
PR [18433](https://github.com/python/mypy/pull/18433)).

(Speaking of partial types, another reminder that mypy plans on enabling `--local-partial-types`
by default in **mypy 2.0**).
Expand All @@ -49,7 +49,7 @@ configuration files. See the
for more details.

Contributed by Mikhail Shiryaev and Shantanu Jain
(PR [16965](https://github.com/python/mypy/pull/16965), PR [18482](https://github.com/python/mypy/pull/18482)
(PR [16965](https://github.com/python/mypy/pull/16965), PR [18482](https://github.com/python/mypy/pull/18482))

### Better line numbers for decorators and slice expressions

Expand Down