Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few PR links in the changelog #18586

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

hamdanal
Copy link
Collaborator

@hamdanal hamdanal commented Feb 2, 2025

And add a local pre-commit hook to detect when a PR number in a link text is different from the link body

And add a local pre-commit hook to detect when a PR number in
a link text is different from the link body
Contributed by Ali Hamdan (PR [18137](https://github.com/python/mypy/pull/18263/)) and
Contributed by Ali Hamdan (PR [18263](https://github.com/python/mypy/pull/18263)) and
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detected with the pre-commit hook

Copy link
Contributor

github-actions bot commented Feb 2, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hauntsaninja hauntsaninja merged commit 1f509ec into python:master Feb 2, 2025
19 checks passed
@hamdanal hamdanal deleted the fix-changelog branch February 3, 2025 07:02
wesleywright pushed a commit that referenced this pull request Feb 5, 2025
And add a local pre-commit hook to detect when a PR number in a link
text is different from the link body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants