Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-90997: Move CACHE handling into _unpack_opargs #92409

Merged
merged 3 commits into from
May 6, 2022

Conversation

brandtbucher
Copy link
Member

_unpack_opargs needs this context to avoid interpreting inline CACHE entries as EXTENDED_ARGs (which happens very easily on big-endian platforms).

@brandtbucher brandtbucher changed the title bpo-90997: Move CACHE handling into _unpack_opargs gh-90997: Move CACHE handling into _unpack_opargs May 6, 2022
@brandtbucher
Copy link
Member Author

brandtbucher commented May 6, 2022

No client of _unpack_opargs expects (or wants) CACHE entries... especially populated ones that look like valid instructions. So not only does this fix bugs in several places, but it probably also makes most dis stuff a tiny bit faster.

@brandtbucher brandtbucher added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 6, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 20a8e09 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 6, 2022
@brandtbucher
Copy link
Member Author

Looks like the first few s390x buildbots are indeed happy with this change.

@pablogsal
Copy link
Member

Thanks a lot @brandtbucher ♥️

@brandtbucher brandtbucher mentioned this pull request May 6, 2022
26 tasks
@brandtbucher brandtbucher deleted the show-caches-fix branch July 21, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants