Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33051: IDLE: Separate editor options from the general tab in config #6082

Closed
wants to merge 2 commits into from

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Mar 11, 2018

Split the 'Editor Preferences' section of the General tab in configdialog into its own tab.

https://bugs.python.org/issue33051

@terryjreedy
Copy link
Member

terryjreedy commented May 17, 2018

I am skimming through some of your open IDLE patches before quitting for the night. In particular, are there any that can/should be merged before 3.7.0c1 next Tuesday? This looks like a straightforward cut/paste with light editing. I still must look at dialog itself. If I like it, YES.

@csabella
Copy link
Contributor Author

@terryjreedy I looked through the other open IDLE patches I have. Two of them have new tests for editor.py, so those would probably be too big to try to look at before Tuesday. I don't know if this is one you'd want to check before then - #5011.

@csabella csabella closed this Jun 4, 2018
@csabella csabella deleted the editortab branch June 4, 2018 17:24
@csabella
Copy link
Contributor Author

csabella commented Jun 4, 2018

Closing this was unintentional but I need to see if I can recreate the branch to reopen it.

Restored and rebased to master.

@vstinner
Copy link
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@terryjreedy
Copy link
Member

Closing as obsolete. init_validators was separately added and used on the existing GenPage. #26621 is a similar patch that separated windows preferences from Shell and Edit preferences. I did it after moving helplist to extensions tab and creating an ExtPage class. Moving indent spaces, #22954, completes the major changes we start around 3 years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants