bpo-32411: IDLE: Remove line number sort in browser.py #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ON HOLD, as explained on the issue. |
terryjreedy
added
performance
terryjreedy
requested changes
May 20, 2018
|
LGTM. |
terryjreedy
changed the title
terryjreedy
approved these changes
Jun 1, 2019
|
@terryjreedy: Please replace |
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 1, 2019
Insertion in line order makes sorting keys by line order unneeded. (cherry picked from commit 1a4d9ff) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
|
GH-13732 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 1, 2019
|
@terryjreedy, thank you! |
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Insertion in line order makes sorting keys by line order unneeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the input dictionary is created in line number and dictionaries are guaranteed to be in insertion order, the sort is no longer needed.
https://bugs.python.org/issue32411