Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-108963: using random to generate unique string in sys.intern test #109491

Merged
merged 6 commits into from
Oct 2, 2023
Merged

gh-108963: using random to generate unique string in sys.intern test #109491

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bdcae08
using random to generate unique string in sys.intern test
aisk Sep 16, 2023
1653d05
remove float in intern test
aisk Sep 19, 2023
a586b39
fix test cases
aisk Sep 19, 2023
4978df9
using random.randrange instead of random.randint and increase range
aisk Sep 19, 2023
785393d
using 9 digits random range in intern test
aisk Sep 21, 2023
14008d9
Merge branch 'main' into fix-gh108963
vstinner Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/test/test_sys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ def test_43581(self):

def test_intern(self):
self.assertRaises(TypeError, sys.intern)
s = "never interned before" + str(random.random())
s = "never interned before" + str(random.int(10**8, 10**9))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random.int doesn't exist. What's the point of putting a minimum at 10**8? Why not 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a more recent commit in the PR fixed the bug. The minimal start is for ensure the random parts have 9 digits, I think it's more consistent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think that the string length (number of random int digits) matters here, does it?

self.assertTrue(sys.intern(s) is s)
s2 = s.swapcase().swapcase()
self.assertTrue(sys.intern(s2) is s)
Expand All @@ -711,7 +711,7 @@ def __hash__(self):

@requires_subinterpreters
def test_subinterp_intern_dynamically_allocated(self):
s = "never interned before" + str(random.random())
s = "never interned before" + str(random.int(10**8, 10**9))
t = sys.intern(s)
self.assertIs(t, s)

Expand Down