Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101454: fix documentation for END_ASYNC_FOR #101455

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 31, 2023

Fixes #101454.

It currently mentions 3-args for the exception, which is out of date, and says it re-raises StopIteration (which is what it does not reraise).

@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 62251c3da06eb4662502295697f39730565b1717 3.11

@bedevere-bot
Copy link

GH-101493 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 1, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Feb 1, 2023
iritkatriel added a commit that referenced this pull request Feb 1, 2023
)

gh-101454: fix documentation for END_ASYNC_FOR (#101455)

(cherry picked from commit 62251c3)
carljm added a commit to carljm/cpython that referenced this pull request Feb 1, 2023
* main:
  pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)
  pythongh-98831: Modernize the LOAD_ATTR family (python#101488)
  pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)
  pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
  pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)
  pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)
  datetime.rst: fix combine() signature (python#101490)
@iritkatriel iritkatriel deleted the async-for branch April 3, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news topic-asyncio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation of END_ASYNC_FOR is out of date and incorrect
4 participants