Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy code for generator based coroutines in asyncio #102748

Closed
kumaraditya303 opened this issue Mar 16, 2023 · 1 comment
Closed

Remove legacy code for generator based coroutines in asyncio #102748

kumaraditya303 opened this issue Mar 16, 2023 · 1 comment
Labels
3.12 bugs and security fixes topic-asyncio

Comments

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Mar 16, 2023 •
edited by bedevere-bot
Loading

Generator based coroutines were long deprecated and removed and asyncio doesn't not supports it. There is some left over code for supporting it which can be removed now.

The first thing is this behavior of asyncio.iscoroutine which makes no sense now. I propose to remove this first.

import asyncio

def gen():
    yield 1

assert not asyncio.iscoroutine(gen()) # fails

Linked PRs
@kumaraditya303 kumaraditya303 added topic-asyncio 3.12 bugs and security fixes labels Mar 16, 2023
@bedevere-bot bedevere-bot mentioned this issue Mar 16, 2023
Merged
kumaraditya303 added a commit that referenced this issue Mar 16, 2023
@kumaraditya303 @AlexWaygood
GH-102748: remove legacy support for generator based coroutines from …
adaed17 
…`asyncio.iscoroutine` (#102749)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
carljm added a commit to carljm/cpython that referenced this issue Mar 17, 2023
@carljm
Merge branch 'main' into inlinecomp2
1a8f4a0 
* main: (34 commits)
  pythongh-102701: Fix overflow in dictobject.c (pythonGH-102750)
  pythonGH-78530: add support for generators in `asyncio.wait` (python#102761)
  Increase stack reserve size for Windows debug builds to avoid test crashes (pythonGH-102764)
  pythongh-102755: Add PyErr_DisplayException(exc) (python#102756)
  Fix outdated note about 'int' rounding or truncating (python#102736)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102760)
  pythongh-99726: Improves correctness of stat results for Windows, and uses faster API when available (pythonGH-102149)
  pythongh-102192: remove redundant exception fields from ssl module socket (python#102466)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102743)
  pythongh-102737: Un-ignore ceval.c in the CI globals check (pythongh-102745)
  pythonGH-102748: remove legacy support for generator based coroutines from `asyncio.iscoroutine` (python#102749)
  pythongh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` (python#102722)
  pythonGH-102653: Make recipe docstring show the correct distribution (python#102742)
  Add comments to `{typing,_collections_abc}._type_repr` about each other (python#102752)
  pythongh-102594: PyErr_SetObject adds note to exception raised on normalization error (python#102675)
  pythongh-94440: Fix issue of ProcessPoolExecutor shutdown hanging (python#94468)
  pythonGH-100112:  avoid using iterable coroutines in asyncio internally (python#100128)
  pythongh-102690: Use Edge as fallback in webbrowser instead of IE (python#102691)
  pythongh-102660: Fix Refleaks in import.c (python#102744)
  pythongh-102738: remove from cases generator the code related to register instructions (python#102739)
  ...
@kumaraditya303 kumaraditya303 mentioned this issue Mar 19, 2023
Closed
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@kumaraditya303 @AlexWaygood @Fidget-Spinner
pythonGH-102748: remove legacy support for generator based coroutines…
a123f26 
… from `asyncio.iscoroutine` (python#102749)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@kumaraditya303 @AlexWaygood @warsaw
pythonGH-102748: remove legacy support for generator based coroutines…
ea7834f 
… from `asyncio.iscoroutine` (python#102749)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@kumaraditya303
Copy link
Contributor Author

I can't anything else to be done in this currently, may reopen if needed later.

@graingert graingert mentioned this issue Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes topic-asyncio
Projects
asyncio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kumaraditya303