Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage of _collections_abc._CallableGenericAlias #102721

Closed
sobolevn opened this issue Mar 15, 2023 · 1 comment
Closed

Improve coverage of _collections_abc._CallableGenericAlias #102721

sobolevn opened this issue Mar 15, 2023 · 1 comment
Assignees
@sobolevn
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Mar 15, 2023 •
edited by bedevere-bot
Loading

Right now several important implementation details of this type is not covered:

  1. Pickle with ParamSpec

Снимок экрана 2023-03-15 в 12 55 15

  1. Invalid type argument

Снимок экрана 2023-03-15 в 12 55 28

Related to #102615 where this was originally discovered.
I will send a PR shortly.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir stdlib Python modules in the Lib dir labels Mar 15, 2023
@sobolevn sobolevn self-assigned this Mar 15, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 15, 2023
@sobolevn
pythongh-102721: Improve coverage of `_collections_abc._CallableGener…
8ed3dd8 
…icAlias`
@bedevere-bot bedevere-bot mentioned this issue Mar 15, 2023
Merged
@AlexWaygood AlexWaygood mentioned this issue Mar 15, 2023
Closed
AlexWaygood added a commit that referenced this issue Mar 16, 2023
@sobolevn @AlexWaygood
gh-102721: Improve coverage of `_collections_abc._CallableGenericAlia…
fbe82fd 
…s` (#102722)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
carljm added a commit to carljm/cpython that referenced this issue Mar 17, 2023
@carljm
Merge branch 'main' into inlinecomp2
1a8f4a0 
* main: (34 commits)
  pythongh-102701: Fix overflow in dictobject.c (pythonGH-102750)
  pythonGH-78530: add support for generators in `asyncio.wait` (python#102761)
  Increase stack reserve size for Windows debug builds to avoid test crashes (pythonGH-102764)
  pythongh-102755: Add PyErr_DisplayException(exc) (python#102756)
  Fix outdated note about 'int' rounding or truncating (python#102736)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102760)
  pythongh-99726: Improves correctness of stat results for Windows, and uses faster API when available (pythonGH-102149)
  pythongh-102192: remove redundant exception fields from ssl module socket (python#102466)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102743)
  pythongh-102737: Un-ignore ceval.c in the CI globals check (pythongh-102745)
  pythonGH-102748: remove legacy support for generator based coroutines from `asyncio.iscoroutine` (python#102749)
  pythongh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` (python#102722)
  pythonGH-102653: Make recipe docstring show the correct distribution (python#102742)
  Add comments to `{typing,_collections_abc}._type_repr` about each other (python#102752)
  pythongh-102594: PyErr_SetObject adds note to exception raised on normalization error (python#102675)
  pythongh-94440: Fix issue of ProcessPoolExecutor shutdown hanging (python#94468)
  pythonGH-100112:  avoid using iterable coroutines in asyncio internally (python#100128)
  pythongh-102690: Use Edge as fallback in webbrowser instead of IE (python#102691)
  pythongh-102660: Fix Refleaks in import.c (python#102744)
  pythongh-102738: remove from cases generator the code related to register instructions (python#102739)
  ...
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 17, 2023
@sobolevn
[3.11] pythongh-102721: Improve coverage of `_collections_abc._Callab…
9b6ebf3 
…leGenericAlias`
@bedevere-bot bedevere-bot mentioned this issue Mar 17, 2023
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 17, 2023
@sobolevn
[3.10] pythongh-102721: Improve coverage of `_collections_abc._Callab…
06a619b 
…leGenericAlias`
@bedevere-bot bedevere-bot mentioned this issue Mar 17, 2023
Merged
miss-islington pushed a commit that referenced this issue Mar 17, 2023
@sobolevn
[3.11] gh-102721: Improve coverage of `_collections_abc._CallableGene…
045c8a1 
…ricAlias` (GH-102788)

This is a backport of #102722 without the `typing.py` changes.

Automerge-Triggered-By: GH:AlexWaygood
miss-islington pushed a commit that referenced this issue Mar 17, 2023
@sobolevn
[3.10] gh-102721: Improve coverage of `_collections_abc._CallableGene…
e732a85 
…ricAlias` (GH-102790)

This is a manual backport of #102722 but without `typing.py` changes and without `TypeVarTuple` case, because it was added in 3.11

Automerge-Triggered-By: GH:AlexWaygood
@AlexWaygood
Copy link
Member

Thanks @sobolevn!

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@sobolevn @AlexWaygood @Fidget-Spinner
pythongh-102721: Improve coverage of `_collections_abc._CallableGener…
dd97b75 
…icAlias` (python#102722)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@sobolevn @AlexWaygood @warsaw
pythongh-102721: Improve coverage of `_collections_abc._CallableGener…
c1672d3 
…icAlias` (python#102722)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @AlexWaygood