Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise ValueError when legacy_repository does not contain any valid package with required version #421

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

pauleikis
Copy link
Contributor

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This fixes #233 in the most straightforwad way, @sdispater please review, maybe there is a better way.

@Aulos
Copy link

Aulos commented Oct 10, 2018

I am having the same issue and this works for me

@sdispater sdispater merged commit 0b33b87 into python-poetry:master Oct 15, 2018
@sdispater
Copy link
Member

Looks good to me 👍

Thanks!

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use private repository in poetry add
3 participants