Raise ValueError when repository does not contain any valid package w…

…ith required version (#421)
python-poetry · Oct 15, 2018 · 0b33b87 · 0b33b87
1 parent f319b55
commit 0b33b87
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/poetry/repositories/legacy_repository.py b/poetry/repositories/legacy_repository.py
@@ -298,6 +298,12 @@ def _get_release_info(self, name, version):  # type: (str, str) -> dict
         }
 
         links = list(page.links_for_version(Version.parse(version)))
+        if not links:
+            raise ValueError(
+                'No valid distribution links found for package: "{}" version: "{}"'.format(
+                    name, version
+                )
+            )
         urls = {}
         hashes = []
         default_link = links[0]

diff --git a/tests/repositories/fixtures/legacy/missing-version.html b/tests/repositories/fixtures/legacy/missing-version.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+  <head>
+    <title>Links for poetry</title>
+  </head>
+  <body>
+    <h1>Links for poetry</h1>
+    <a href="poetry-0.1.0-py3-none-any.whl#sha256=1d85132efab8ead3c6f69202843da40a03823992091c29f8d65a31af68940163" data-requires-python="&gt;=3.6.0">poetry-0.1.0-py3-none-any.whl</a><br/>
+    </body>
+</html>
+<!--SERIAL 3907384-->
diff --git a/tests/repositories/test_legacy_repository.py b/tests/repositories/test_legacy_repository.py
@@ -1,3 +1,5 @@
+import pytest
+
 from poetry.repositories.legacy_repository import LegacyRepository
 from poetry.repositories.legacy_repository import Page
 from poetry.utils._compat import Path
@@ -50,3 +52,10 @@ def test_http_basic_auth_repo(mocker):
 
     mock.assert_called_once_with("legacy")
     assert repo._session.auth == ("user1", "p4ss")
+
+
+def test_missing_version(mocker):
+    repo = MockRepository()
+
+    with pytest.raises(ValueError):
+        repo._get_release_info("missing_version", "1.1.0")