Added gs_binary to control Ghostscript use on all platforms #7392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Sep 12, 2023
docs/handbook/image-file-formats.rst
Outdated
| @@ -88,8 +88,14 @@ in ``L``, ``RGB`` and ``CMYK`` modes. | |||
| Loading | |||
| ~~~~~~~ | |||
|
|
|||
| To use Ghostscript, Pillow searches for the "gs" executable. On Windows, it | |||
| also searches for "gswin32c" and "gswin64c". If you would like to customise | |||
There was a problem hiding this comment.
Bit more concise:
Suggested change
| also searches for "gswin32c" and "gswin64c". If you would like to customise | |
| also searches for "gswin32c" and "gswin64c". To customise |
There was a problem hiding this comment.
Sure. I've pushed a commit so that I could rearrange the lines ending as well, and shortened another bit of text later on.
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7391
The user in that issue would like an API to prevent Ghostscript use. Since we already have
EpsImagePlugin.gs_windows_binarythat stores the name of the Ghostscript binary on Windows,Pillow/src/PIL/EpsImagePlugin.py
Line 40 in e188954
this PR suggests adding
EpsImagePlugin.gs_binary, that stores the name of the Ghostscript binary on all platforms.Setting it to false would result in
OSError: Unable to locate Ghostscript on pathswhen trying to load an EPS image.