Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6486 refactors the DDS plugin, but also adds support for reading BC5U images. This PR adds that new support, without refactoring.
https://walbourn.github.io/the-dds-file-format-lives/ mentions
Here are the settings we currently use for that format as part of DX10
Pillow/src/PIL/DdsImagePlugin.py
Lines 189 to 192 in 2460621
So those same settings can be used when
fourcc
is "BC5U", making it the same as our existingfourcc
of "ATI2"Pillow/src/PIL/DdsImagePlugin.py
Lines 176 to 179 in 2460621
I created a test image by copying and hexeditting our ATI2 test image.