Added fallback for finding ld on MinGW Cygwin #4019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion to resolve #4018
The mingw32 job is currently failing with
Searching, I found that in 'C:/msys64/mingw32/lib/python3.7\distutils\cygwinccompiler.py', there is a part where it stops searching for a simple 'ld' executable, instead searching for the path specified by gcc.
However, I think this path then ends up being /usr/lib/gcc/x86_64-pc-msys/9.1.0/../../../../x86_64-pc-msys/bin/ld.exe
So this PR uses pacman versions of pytest and pytest-cov instead of compiling from source, and adds a fallback when compiling Pillow, trying 'ld' again if the gcc path does not work.