Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fallback for finding ld on MinGW Cygwin #4019

Merged
merged 1 commit into from
Aug 11, 2019

Conversation

radarhere
Copy link
Member

Suggestion to resolve #4018

The mingw32 job is currently failing with

if self.ld_version >= "2.10.90":
    TypeError: '>=' not supported between instances of 'NoneType' and 'str'

Searching, I found that in 'C:/msys64/mingw32/lib/python3.7\distutils\cygwinccompiler.py', there is a part where it stops searching for a simple 'ld' executable, instead searching for the path specified by gcc.

ld = 'ld'
out = Popen(gcc+' --print-prog-name ld', shell=True, stdout=PIPE).stdout
try:
	ld = test=str(out.read(),encoding='utf-8').strip()

However, I think this path then ends up being /usr/lib/gcc/x86_64-pc-msys/9.1.0/../../../../x86_64-pc-msys/bin/ld.exe

So this PR uses pacman versions of pytest and pytest-cov instead of compiling from source, and adds a fallback when compiling Pillow, trying 'ld' again if the gcc path does not work.

@radarhere radarhere changed the title Added workaround for finding ld on MinGW Cygwin Added fallback for finding ld on MinGW Cygwin Aug 10, 2019
@hugovk
Copy link
Member

hugovk commented Aug 11, 2019

Thanks!

@hugovk hugovk merged commit 6de118a into python-pillow:master Aug 11, 2019
@radarhere radarhere deleted the msys2 branch August 11, 2019 20:53
@radarhere radarhere mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: AppVeyor mingw32 build failing
2 participants