-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace distutils #4796
Comments
I'm not certain that we need to remove The import of When we moved the MinGW job from AppVeyor to GitHub Actions, this code actually stopped being run by our CIs - the problem doesn't occur on GHA. setuptools doesn't use gcc to try and find the path. So once distutils is no more, this code can be safely removed. If we wanted to remove it now, I think there are only two alternatives. Either add code to ensure that setuptools distutils is used, rather than Python distutils, or if a user ever reports it, suggest that they investigate how to correctly connect gcc with ld. |
I've created msys2/MINGW-packages#6744 to see if the fallback behaviour can be incorporated into the MinGW patches. |
While working on #4890, I've just realized the actual cause of #4018, and the proper fix. The issue was that AppVeyor was missing the After adding the envvar in my branch nulano/Pillow@master...nulano:mingw-test2, the build passes on AppVeyor. After removing I've therefore removed the GCC workaround in #4890. |
#4890 was the last step. distutils is no longer imported by Pillow. |
There's an effort underway to move the functionality of distutils into Setuptools and other libraries, with a goal to remove distutils from the standard library.
Re:
Here's where we're using disutils:
Tests/test_image_access.py
andsetup.py
from distutils import ccompiler, sysconfig
Tests/test_imagefont.py
distutils.version.StrictVersion
packaging.version.parse
#4797setup.py
from distutils.command.build_ext import build_ext
from setuptools.command.build_ext import build_ext
#4829setup.py
from distutils import cygwinccompiler
The text was updated successfully, but these errors were encountered: