Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mimetype with content_type #699

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Oct 21, 2023

Update Request and Response protocols. Move mimetype to content_type to include content parameters. Required to work with media type deserializing.

Backward incompatibility

@p1c2u p1c2u force-pushed the feature/move-mimetype-to-content-type branch 6 times, most recently from 1d2997b to 7c94928 Compare October 21, 2023 16:56
@p1c2u p1c2u changed the title Move request mimetype to content_type Replace mimetype with content_type Oct 21, 2023
@p1c2u p1c2u force-pushed the feature/move-mimetype-to-content-type branch from 7c94928 to 13ba0dc Compare October 21, 2023 17:01
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #699 (2a3bd96) into master (cc95ed0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
- Coverage   90.94%   90.94%   -0.01%     
==========================================
  Files         127      127              
  Lines        3856     3855       -1     
  Branches      476      475       -1     
==========================================
- Hits         3507     3506       -1     
  Misses        289      289              
  Partials       60       60              
Files Coverage Δ
openapi_core/contrib/aiohttp/requests.py 93.54% <100.00%> (ø)
openapi_core/contrib/aiohttp/responses.py 87.50% <100.00%> (ø)
openapi_core/contrib/django/requests.py 95.83% <100.00%> (+0.18%) ⬆️
openapi_core/contrib/django/responses.py 100.00% <100.00%> (ø)
openapi_core/contrib/falcon/requests.py 92.85% <100.00%> (ø)
openapi_core/contrib/falcon/responses.py 92.30% <100.00%> (ø)
openapi_core/contrib/requests/requests.py 88.23% <100.00%> (ø)
openapi_core/contrib/requests/responses.py 100.00% <100.00%> (ø)
openapi_core/contrib/starlette/requests.py 78.12% <100.00%> (-1.88%) ⬇️
openapi_core/contrib/starlette/responses.py 77.27% <100.00%> (ø)
... and 9 more

@p1c2u p1c2u force-pushed the feature/move-mimetype-to-content-type branch from 13ba0dc to d99c7e4 Compare October 21, 2023 18:14
@p1c2u p1c2u force-pushed the feature/move-mimetype-to-content-type branch from d99c7e4 to 2a3bd96 Compare October 21, 2023 18:31
@p1c2u p1c2u merged commit efaa5ac into master Oct 21, 2023
18 checks passed
@p1c2u p1c2u deleted the feature/move-mimetype-to-content-type branch October 21, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant