HTTP content-type isn't using charset #689
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a typical API-schema, content types don't have charsets. For example application/json charset is assumed to be UTF-8 by RFC 8259. For example text/xml, there is relevance. In neither case API-schema doesn't specify multiple contents for different charsets.
Thus, not using HTTP-response charset for API-schema verification doesn't make sense. For those response verifications with assumed charset, there is no need to fail. For those responses which are in varying charsets, verifying data is impossible as there is no decoding the response data into Unicode used by Python internally. Again, charset doesn't have any relevance and can be ignored.
Ref.: https://datatracker.ietf.org/doc/html/rfc2046#section-4.1.2
Ref.: https://datatracker.ietf.org/doc/html/rfc8259#section-8.1