Declare Python 3.4 as incompatible #807
Conversation
Python 3.4 testing has been dropped in python-attrs#608, but it was not declared as incompatible in setup.py because the code base was expected to still work with Python 3.4 for a while. This compatibility finally broke with the 21.1.0 release. At least one of the problematic commits is e09b1d6 introducing an import of the typing module not available in Python 3.4.
|
Ah yes I wanted to test it before releasing but found it too cumbersome to find a working 3.4. 🙈 |
|
Hi @hynek, I just encountered this in my CI. Would you consider yanking 21.1.0 and posting a new release with the correct |
|
Yes, I was thinking that (I'll yank once 21.2 is out). |
|
21.2 is on PyPI, 21.1 is yanked. |
See python-attrs/attrs#807, thank you to @mwaskom for finding this
* fix bug in creating training weights directory * Remove Py 3.4 testing See python-attrs/attrs#807, thank you to @mwaskom for finding this Co-authored-by: Jasmine Stone <jasminetstone@gmail.com>
|
Just a heads up: unfortunately it seems that the last pip version compatible with Python 3.4 predates yanking packages, so it still finds 21.1.0. So those of us still testing on 3.4 have to work around this by specifying This isn't a criticism - it's just part of the reality of keeping older things working. I just thought I'd leave a note here for anyone else wondering why the problem doesn't seem to be solved. 🙂 |
|
Aw crap, I hoped/thought yanking’s served-side. :( Thanks for letting us know Thomas! |
|
No worries. Unfortunately, I think there's no way it could be purely server side and still allow the yanked version to be installed if that specific version is pinned, because pip doesn't tell the server that it's looking for a specific version. |
The attrs release 21 is incompatible with Python 3.4 and while yanked, the pip that would be around with Python 3.4 doesn't understand yanking and so installs it anyway. See python-attrs/attrs#807
The attrs release 21 is incompatible with Python 3.4 and while yanked, the pip that would be around with Python 3.4 doesn't understand yanking and so installs it anyway. See python-attrs/attrs#807
The attrs release 21 is incompatible with Python 3.4 and while yanked, the pip that would be around with Python 3.4 doesn't understand yanking and so installs it anyway. See python-attrs/attrs#807
Python 3.4 testing has been dropped in #608, but it was not declared as incompatible in setup.py because the code base was expected to still work with Python 3.4 for a while. This compatibility finally broke with the 21.1.0 release. At least one of the problematic commits is e09b1d6 introducing an import of the typing module not available in Python 3.4.
Trying to import attr with Python 3.4 gives the following exception:
Alternatively, it might be a possibility to add the typing backport as dependency for Python 3.4 installs. But I suppose this is not desired as official Python 3.4 support has been dropped.