Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Py34 testing in TravisCI due to attrs change #46

Merged
merged 1 commit into from
May 8, 2021

Conversation

LevN0
Copy link
Member

@LevN0 LevN0 commented May 8, 2021

attrs>20.0.3 drops support for Py34. See python-attrs/attrs#807.

@LevN0 LevN0 force-pushed the fix_travis_py34 branch 13 times, most recently from b8b3f00 to 467d099 Compare May 8, 2021 17:23
@LevN0 LevN0 force-pushed the fix_travis_py34 branch from 467d099 to 575edbb Compare May 8, 2021 17:28
@LevN0 LevN0 merged commit 66aad4f into Small-Bodies-Node:master May 8, 2021
@LevN0
Copy link
Member Author

LevN0 commented May 8, 2021

attrs yanked the broken version that still declares py34 support, but latest pip version with support for py34 ignores the yank and tries to install it anyway (at least as far as I can see). Thus the issue that had to be worked around here.

@LevN0 LevN0 deleted the fix_travis_py34 branch May 8, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant