Pin runtime and test dependencies #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
Constrained pytest to v7.1.1. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…testing" extra. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
… tox environment. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
… into the file pytest-min-requirements.txt. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…st-min-requirements. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…ent directories. This allows Dependabot to update both dependency sets independently. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…ing" extra. Adjusted constraints accordingly. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…testing" extra. Adjusted constraints accordingly. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
seifertm
force-pushed
the
pin-dependencies
branch
from
bb63aa1 to
5c0a641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
pytest-asyncio builds have previously failed due to breaking changes of test dependencies (#302) or build-time dependencies (#314). Issue #305 aims to introduce version pinning to the project dependencies to avoid those types of issues in the future.
Scope
This PR introduces version pinning for runtime dependencies.
At the moment runtime dependencies are declared in two places:
setup.cfgandtox.ini. This PR does not address the fact that dependencies are declared in different places. It does not address pinning of build-time dependencies, either.Changes
Runtime dependencies for
testenvandtestenv:pytest-minwere moved torequirements.txtfiles independencies/default/anddependencies/pytest-min, respectively. Each of the dependency sets contains aconstraints.txtto pin the dependency versions.Dependabot is supposed to automatically bump the entries in
constraints.txt.Additionally, this PR, declares runtime and test dependencies with lower bound (e.g.
coverage >= 6.2) rather than fixed versions (coverage==6.2), where possible.Benefit
I'd be happy to hear your feedback on this!