Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependency versions #305

Closed
seifertm opened this issue Mar 7, 2022 · 1 comment
Closed

Pin dependency versions #305

seifertm opened this issue Mar 7, 2022 · 1 comment

Comments

@seifertm
Copy link
Contributor

seifertm commented Mar 7, 2022

pytest-asyncio has dependencies on a bunch of other pytest plugins, in order to ensure mutual compatibility. These tests are run as part of the CI.

CI will always install the latest versions of test dependencies. When one of the dependencies releases a breaking change, the CI pipeline will fail, even if no changes in pytest-asyncio have been made. This prevents us from merging any PRs unless the breaking change is addressed. Forc merging of red PRs is still an option, but not ideal.

I propose to make use of Pip's constraints.txt to pin dependency versions. I would expect dependabot to take care of updating the pinned versions.

@seifertm
Copy link
Contributor Author

Runtime and test dependencies are pinned to ensure reproducible builds. Build dependencies are currently not pinned. While there seem to be ways to do it, it's not supported by build at the moment (see pypa/build#292).

The current state should be good enough. Closing this for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant