2fa disabling ask password -- Take 2

[yeraydiazdiaz]

Closes #5825

This PR builds on top of #6408 and fixes the errors reported by @di

The errors originated on the refactor of the modal template code:

• The name attribute on the input tag was accidentally deleted which caused the all other "confirm" modal forms to fail.
• A call with an index kwarg was left behind which caused the traceback @di posted.

Here's a capture of the reported broken funcionality working with this PR:

I'd appreciate a further round of tests before merging if at all possible.

[nlhkabu]

I confirm that the other modals are now working again.

[nlhkabu]

@yeraydiazdiaz I'd like to ask for the user's password instead of their username when deleting an account. Do you think it's something we could add to this PR?

[yeraydiazdiaz]

Thanks for verifying @nlhkabu. Yes, I can add that as well.

[yeraydiazdiaz]

@nlhkabu I've added confirming the password on account deletion. Here's a capture:

[brainwane]

@di can you review?

[di]

I'm not seeing how we can get rid of index here -- it's important for distinguishing between multiple of the same form on the same page (i.e., the delete releases page).

[nlhkabu]

@yeraydiazdiaz could you please ensure that the modal content is translatable, e.g.
https://github.com/pypa/warehouse/pull/6598/files#diff-fdc9c6c54285180f385c5f8c0609ccc1R111

This will ensure we don't revert changes from #6598

Thanks

[nlhkabu]

@di are we ready to go here?

@yeraydiazdiaz since we have now merged the translations PR (see #6598) we will need to rebase this, making sure that all {% trans %} blocks remain in place.

[di]

LGTM

[pradyunsg]

A minor nit: after deleting the account, there's no indication that the action was indeed successful. I'm not sure how difficult it might be to add, but that was something I found myself surprized to not see in the GIF above.

[di]

@pradyunsg In the GIF @yeraydiazdiaz is using the incorrect password, so the account doesn't actually delete -- there's a warning, and then the GIF loops.

If the password was correct, the user would have been logged out, which is probably indication enough that it was successful. And since the user is logged out, we can't flash a message. The only other thing we could do would be to redirect to a page that is specifically for confirming that account deletion was successful, but I'm not sure that's worth doing. If you do though, please feel free to create an issue!

[pradyunsg]

Thanks for the quick response @di! Reading your description, I don't think there's any change needed here IMO. :)