2fa disabling ask password #6408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodruffw
reviewed
Aug 11, 2019
|
Hi @yeraydiazdiaz, thanks for this PR 😁 A couple of items: Could we please update the error text (when a user enters an incorrect password) to be more meaningful than 'invalid credentials'?
Maybe something like: Can we also please use this functionality for the 'remove API token' modal as well? Thanks! |
|
@yeraydiazdiaz is this ready for re-review? |
|
Yes, it is. Here is a capture of the changes requested by @nlhkabu
|
di
reviewed
Aug 14, 2019
added 14 commits
August 15, 2019 10:10
Remove unused `index` parameter
Allow `username` to be set as an instance variable
Avoid passing the username to constructor simplifying base class
yeraydiazdiaz
force-pushed
the
2fa-disabling-ask-password
branch
from
c1af5ac to
46fc81f
Compare
|
I've implemented the change suggested by @di and rebased on master, this is ready for re-review. |
di
approved these changes
Aug 15, 2019
|
I merged master onto this branch and had to update the some of the tests, I believe everything's correct but @woodruffw could you review again just in case? |
nlhkabu
approved these changes
Aug 24, 2019
|
Thank you @yeraydiazdiaz ! 🎉 |
di
added a commit
that referenced
this pull request
Aug 24, 2019
This was referenced Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5825
Here's a capture of the new functionality: