Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call setuptools.extern.importlib_metadata.EntryPoints.names for better backwards compatibility. #4339

Merged

Conversation

abravalheri
Copy link
Contributor

Summary of changes

  • Don't call setuptools.extern.importlib_metadata.EntryPoints.names, instead just iterate over entry_points (this is the same underlying implementation, but it is backwards compatible).

Closes #4338

Pull Request Checklist

@abravalheri abravalheri marked this pull request as ready for review May 1, 2024 16:55
@abravalheri abravalheri merged commit dcfc833 into pypa:main May 2, 2024
22 checks passed
@abravalheri abravalheri deleted the avoid-importlib-metadata-newer-api branch May 2, 2024 11:25
@abravalheri
Copy link
Contributor Author

Merging based on this comment:

Ideally, I'd like for setuptools to be able to rely on whatever version of "importlib metadata" is available in the environment.

(As it implies that setuptools should be able to deal with older importlib_metadata installations.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant