-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve interop with importlib.metadata
: variation without importlib_metadata
#199
base: main
Are you sure you want to change the base?
Conversation
Thanks! Does this somehow avoid the exception you found in setuptools tests in this comment? |
For setuptools, it should be fine abravalheri/setuptools#14 (tests should OK, docs failing but that is unrelated). (I went ahead and already added fixed the |
Aha, so this is functionally similar to the original version of #195 (before involving I prefer this approach. I'll give it a day or so in case anyone else wants to weigh in, but if not then I'd like to merge this and cut another release. |
It is very nuanced 😅 The reason for introducing Trying to import If setuptools did not have to use vendoring, then yes using |
What are the next steps for this to be merged? |
- Bump PORTREVISION for package change PR: 280646 Obtained from: pypa/pyproject-hooks#199
- Bump PORTREVISION for package change PR: 280646 Obtained from: pypa/pyproject-hooks#199
Hi @takluyver, @jaraco (and/or any other maintainers) is this approach (or the one in #195 which includes |
I unfortunately have paged out the rich context, but I agree that it sounds as if this narrow and surgical fix may be a very solid improvement. Let's go with it for now. Thanks for the diligent investigation and proposal. |
This is basically the same as #195 but without using
importlib_metadata
.Feel free to close if #195 is preferred.
This might be worthy considering:
i.e. while this approach decreases the "spooky action at distance" of a transitive dependency installing
importlib_metadata
, it may also be more error prone if some dependency is indeed usingimportlib_metadata
.Closes #192