-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a coverage job for Python 3 #4862
Conversation
Aside -- we're currently at 56% so, need a lot more unit tests. :) I have a bucket list of refactors lined up next year and hopefully will make one pass over the entire unit test suite in the coming 6 months. :) |
@@ -14,6 +14,10 @@ commands = py.test --timeout 300 [] | |||
install_command = python -m pip install {opts} {packages} | |||
usedevelop = True | |||
|
|||
[testenv:coverage-py3] | |||
basepython = python3 | |||
commands = py.test --timeout 300 --cov=pip --cov-report=term-missing --cov-report=xml --cov-report=html tests/unit {posargs} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/unit {posargs}
-> {posargs:tests/unit}
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cryvate! :)
I don't think in the near future anyone would want to pass any other directory for measuring coverage. pip's integration tests spawn subprocesses, which won't get tracked in the coverage metrics.
Thanks for the review @xavfernandez! ^>^ PS: I'm pretty sure I overuse text-emoji but that's probably fine. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #3751 (this is that carried forward)
I'd like to use this command.