Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a coverage job for Python 3 #4862

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

pradyunsg
Copy link
Member

Closes #3751 (this is that carried forward)

I'd like to use this command.

@pradyunsg pradyunsg added type: maintenance Related to Development and Maintenance Processes C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes) labels Nov 14, 2017
@pradyunsg pradyunsg self-assigned this Nov 14, 2017
@pradyunsg pradyunsg requested a review from a team November 14, 2017 06:33
@pradyunsg
Copy link
Member Author

Aside -- we're currently at 56% so, need a lot more unit tests. :)

I have a bucket list of refactors lined up next year and hopefully will make one pass over the entire unit test suite in the coming 6 months. :)

@@ -14,6 +14,10 @@ commands = py.test --timeout 300 []
install_command = python -m pip install {opts} {packages}
usedevelop = True

[testenv:coverage-py3]
basepython = python3
commands = py.test --timeout 300 --cov=pip --cov-report=term-missing --cov-report=xml --cov-report=html tests/unit {posargs}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/unit {posargs} -> {posargs:tests/unit} maybe?

Copy link
Member Author

@pradyunsg pradyunsg Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cryvate! :)

I don't think in the near future anyone would want to pass any other directory for measuring coverage. pip's integration tests spawn subprocesses, which won't get tracked in the coverage metrics.

@pradyunsg
Copy link
Member Author

Thanks for the review @xavfernandez! ^>^

PS: I'm pretty sure I overuse text-emoji but that's probably fine.

@pradyunsg pradyunsg merged commit 9ec42b6 into pypa:master Nov 15, 2017
@pradyunsg pradyunsg deleted the misc/coverage-job-tox branch November 15, 2017 08:32
@pradyunsg pradyunsg restored the misc/coverage-job-tox branch May 27, 2018 09:38
@pradyunsg pradyunsg deleted the misc/coverage-job-tox branch May 27, 2018 10:09
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: tests Testing and related things skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants