tox.ini: Add "cover" target #3751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that measures coverage for unit tests only. Functional tests are slow enough already and a lot of them fail when coverage is measured, because they fork processes and them emit warnings to stderr that the tests are not expecting. I think it's a good thing to try to increase unit test coverage and this lets us measure and see where the gaps are. And it will help folks realize if they increased or decreased coverage with their changes.
|
@xavfernandez Is coverage a useful metric to be tracking? |
|
I personally like it 👍 |
|
ugh. Okay BrownTruck. @pypa/pip-committers Should we close this PR and move to an issue for discussion? |
|
I think we could merge this as is if someone wants to have a coverage run (without adding an other travis run)/ |
xavfernandez
added
the
skip news
|
I've made #4862. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that measures coverage for unit tests only. Functional tests are slow
enough already and a lot of them fail when coverage is measured, because
they fork processes and them emit warnings to stderr that the tests are
not expecting.
I think it's a good thing to try to increase unit test coverage and this
lets us measure and see where the gaps are. And it will help folks
realize if they increased or decreased coverage with their changes.
This was automatically migrated from #2546 to reparent it to the
masterbranch. Please see original pull request for any previous discussion.Original Submitter: @msabramo