Avoid pip.main leaking loggers - fixes #3043 #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstufft
added
the
skip news
|
Adding trivial flag to satisfy the news file requirement. It looks like you have PEP8 failures that will need to be fixed before this can be merged. |
dstufft
added
needs changes
needs rebase or merge
|
It looks like the PEP8 failures are fixed, sadly now it looks like the rebase got messed up and you've pulled in extra unneeded commits. If you can fix that so this is just your one commit, then I can merge this. |
dstufft
requested changes
Apr 1, 2017
|
Done |
dstufft
approved these changes
Apr 2, 2017
|
Thanks! |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.