Merge pull request #4394 from Lucas-C/master

Avoid pip.main leaking loggers - fixes #3043
pypa · Apr 2, 2017 · 07e7912 · 07e7912
2 parents 5748d87 + 3b3dfac
commit 07e7912
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/pip/basecommand.py b/pip/basecommand.py
@@ -210,6 +210,8 @@ def main(self, args):
                 )
                 sys.exit(VIRTUALENV_NOT_FOUND)
 
+        original_root_handlers = set(logging.root.handlers)
+
         try:
             status = self.run(options, args)
             # FIXME: all commands should return an exit status
@@ -249,6 +251,10 @@ def main(self, args):
                         retries=0,
                         timeout=min(5, options.timeout)) as session:
                     pip_version_check(session, options)
+            # Avoid leaking loggers
+            for handler in set(logging.root.handlers) - original_root_handlers:
+                # this method benefit from the Logger class internal lock
+                logging.root.removeHandler(handler)
 
         return SUCCESS