Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pipenv "state of project" caveat #729

Merged
merged 4 commits into from
Jun 22, 2020
Merged

Remove pipenv "state of project" caveat #729

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdda776
Remove April caveat, add pre-release notice
mavaddat May 25, 2020
4ab0244
restored caveat with some wording changes
mavaddat May 28, 2020
9730a98
tidied up the language
mavaddat May 28, 2020
0d5ca10
remove caveat entirely
mavaddat May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions source/tutorials/managing-dependencies.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,31 +26,6 @@ as Python libraries, should also consider the
`poetry <https://github.com/python-poetry/poetry>`_ project as an alternative dependency
management solution.


Recommendation caveats (as of April 2020)
-----------------------------------------

While this tutorial covers the ``pipenv`` project as a tool that focuses
primarily on the needs of Python application development rather than Python
library development, the project itself is currently working through several
`process and maintenance issues <https://github.com/pypa/pipenv/issues/3369>`_
that are preventing bug fixes and new features from being published (with the
entirety of 2019 passing without a new release).

This means that in the near term, ``pipenv`` still suffers from several quirks
and performance problems without a clear timeline for resolution of those isses.
Copy link
Member

@pradyunsg pradyunsg May 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you do that, please also fix the "isses" typo. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that typo was actually what motivated me to contribute to the tutorial in the first place!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me needs to start planting more typos into tutorials to motivate grammar-nazi


While this remains the case, project maintainers are likely to want to
investigate :ref:`other-dependency-management-tools` for use instead of, or
together with, ``pipenv``.

Assuming the April 2020 ``pipenv`` release goes ahead as planned, and the
release after that also remains on track, then this caveat on the tutorial will
be removed. If those releases *don't* remain on track, then the tutorial itself
will be removed, and replaced with a discussion page on the available dependency
management options.


Installing Pipenv
-----------------

Expand Down