Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pipenv "state of project" caveat #729

Merged
merged 4 commits into from
Jun 22, 2020
Merged

Conversation

mavaddat
Copy link
Contributor

The pipenv team hit their April and May release targets, so the caveat about the seeming impasse of pipenv development no longer applies. However, it may benefit the user to know that the early access version of the package is available as pre-release in pip.

The pipenv team hit their April and May release targets, so the caveat about the seeming impasse of pipenv development no longer applies. However, it may benefit the user to know that the early access version of the package is available as pre-release in `pip`.
@pradyunsg
Copy link
Member

I think we should wait for a stable release prior to merging this.

@ncoghlan
Copy link
Member

It would be good to at least reword the caveat with a pointer to the pre-release, though - at the time I wrote it, even that wasn't out yet.

We're also past the worst of the release roadblocks now (prior to that first pre-release, things had atrophied to the point where even Dan couldn't readily push a new release to PyPI)

@webknjaz
Copy link
Member

+1 to reword, removing completely shouldn't be done until it's stable

@pradyunsg
Copy link
Member

pradyunsg commented May 27, 2020

@mavaddat Would you be willing to re-add the caveat, update the heading of the caveat to say June instead of April (we can wait a couple of days before merging) and reword a couple of sentences in the section, pointing to the pre-release that's been made already?

entirety of 2019 passing without a new release).

This means that in the near term, ``pipenv`` still suffers from several quirks
and performance problems without a clear timeline for resolution of those isses.
Copy link
Member

@pradyunsg pradyunsg May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you do that, please also fix the "isses" typo. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that typo was actually what motivated me to contribute to the tutorial in the first place!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me needs to start planting more typos into tutorials to motivate grammar-nazi

I re-ordered the phrasing to give the reader a sense of the big picture first. Also, I attempted to clarify the language about library vs application development. However, I am not sure if I captured the spirit of what was intended by those words by the previous author.
I removed some redundant language.
@ncoghlan
Copy link
Member

Heh, naturally the release happens after we had decided to keep the caveat until then: https://pypi.org/project/pipenv/2020.5.28/ :)

@pradyunsg
Copy link
Member

Another green tick, and I'll be happy to merge. :)

@pradyunsg pradyunsg changed the title Remove April caveat, add pre-release notice Remove pipenv "state of project" caveat Jun 22, 2020
@pradyunsg pradyunsg merged commit 19bc7ae into pypa:master Jun 22, 2020
@pradyunsg
Copy link
Member

Thanks @mavaddat! ^>^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants